Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38602 )
Change subject: asus/p2b-ls: Drop SCSI from devicetree
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38602/1/src/mainboard/asus/p2b-ls/d...
File src/mainboard/asus/p2b-ls/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38602/1/src/mainboard/asus/p2b-ls/d...
PS1, Line 51: device pci 6.0 on end # Onboard SCSI
I'd prefer if the device was kept here, so that it helps document the mainboard.
I'd prefer to keep it commented out, as the entry adds code to ramstage. With only 256KiB flash every byte counts.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38602
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ee9cd605bf4c22561f826945be1374fd8257c82
Gerrit-Change-Number: 38602
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 02 Feb 2020 17:45:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment