Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45411 )
Change subject: soc/intel/common/block: Fix Klocwork issue ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45411/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45411/1//COMMIT_MSG@7 PS1, Line 7: soc/intel/common/block: Fix Klocwork issue
It’d be great to describe the action in the git commit message summary.
Ack
https://review.coreboot.org/c/coreboot/+/45411/1//COMMIT_MSG@11 PS1, Line 11: 2. Initialize pointer soc_config with NULL
I'd prefer one commit per change, too.
Ack
https://review.coreboot.org/c/coreboot/+/45411/1/src/soc/intel/common/block/... File src/soc/intel/common/block/chip/chip.c:
https://review.coreboot.org/c/coreboot/+/45411/1/src/soc/intel/common/block/... PS1, Line 8: const struct soc_intel_common_config *soc_config = NULL; : const config_t *config; : : config = config_of_soc(); : soc_config = &config->common_soc_config; : : return soc_config;
This could just be `return &config_of_soc()->common_soc_config;`
Ack
https://review.coreboot.org/c/coreboot/+/45411/1/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/45411/1/src/soc/intel/common/block/... PS1, Line 174: return
I'd just skip over the `vb2api_fail` and `vboot_save_data` calls. […]
Thanks a lot.