Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55170 )
Change subject: mb/google/brya: Set SerialIoI2cMode for I2C4 as PchSerialIoDisabled
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55170/comment/d8d0f917_8e7caf0a
PS1, Line 8:
Why this change is desired wasn't obvious to me. I'd add the following:
I2C4 is not used on Brya. Thus, disable it in SerialIoI2cMode.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55170
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I94c72b7fac9d8a001913b5faa2c0c8a3e8b701e9
Gerrit-Change-Number: 55170
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Thu, 03 Jun 2021 16:47:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment