Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40421 )
Change subject: soc/amd/picasso: Allow mainboard to configure SPI settings
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40421/8/src/soc/amd/picasso/chip.h
File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/40421/8/src/soc/amd/picasso/chip.h@...
PS8, Line 84: spi_read_mode
Instead of placing all these in the main picasso config, would it be cleaner if we defined a SPI chip in the device tree?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40421
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I24c27ec39101c7c07bedc27056f690cf2cc54951
Gerrit-Change-Number: 40421
Gerrit-PatchSet: 8
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 29 Apr 2020 21:17:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment