[coreboot-gerrit] [S] Change in coreboot[master]: soc/intel/baytrail: Move a function inside a file

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74325 )

Change subject: soc/intel/baytrail: Move a function inside a file
......................................................................

soc/intel/baytrail: Move a function inside a file

This avoids unnecessary forward declaration of another
statically defined function.

Change-Id: Id362e023358054df2c4511fd108c313da868306d
Signed-off-by: Kyösti Mälkki 
---
M src/soc/intel/baytrail/acpi.c
M src/soc/intel/baytrail/include/soc/acpi.h
2 files changed, 24 insertions(+), 12 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/74325/1

diff --git a/src/soc/intel/baytrail/acpi.c b/src/soc/intel/baytrail/acpi.c
index 4d5b5c2..c6b5a18 100644
--- a/src/soc/intel/baytrail/acpi.c
+++ b/src/soc/intel/baytrail/acpi.c
@@ -85,16 +85,6 @@
    return sci_irq;
 }

-unsigned long acpi_fill_madt(unsigned long current)
-{
-	/* IOAPIC */
-	current += acpi_create_madt_ioapic_from_hw((acpi_madt_ioapic_t *)current, IO_APIC_ADDR);
-
-	current = acpi_madt_irq_overrides(current);
-
-	return current;
-}
-
 static acpi_tstate_t soc_tss_table[] = {
    { 100, 1000, 0, 0x00, 0 },
    {  88,  875, 0, 0x1e, 0 },
@@ -286,7 +276,7 @@
    acpigen_write_processor_cnot(pattrs->num_cpus);
 }

-unsigned long acpi_madt_irq_overrides(unsigned long current)
+static unsigned long acpi_madt_irq_overrides(unsigned long current)
 {
    int sci_irq = acpi_sci_irq();
    acpi_madt_irqoverride_t *irqovr;
@@ -306,3 +296,13 @@

return current;
 }
+
+unsigned long acpi_fill_madt(unsigned long current)
+{
+	/* IOAPIC */
+	current += acpi_create_madt_ioapic_from_hw((acpi_madt_ioapic_t *)current, IO_APIC_ADDR);
+
+	current = acpi_madt_irq_overrides(current);
+
+	return current;
+}
diff --git a/src/soc/intel/baytrail/include/soc/acpi.h b/src/soc/intel/baytrail/include/soc/acpi.h
index d629b24..b747db7 100644
--- a/src/soc/intel/baytrail/include/soc/acpi.h
+++ b/src/soc/intel/baytrail/include/soc/acpi.h
@@ -6,6 +6,5 @@
 #include <acpi/acpi.h>

int acpi_sci_irq(void);
-unsigned long acpi_madt_irq_overrides(unsigned long current);

#endif /* _BAYTRAIL_ACPI_H_ */