Attention is currently required from: Martin L Roth.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67191 )
Change subject: util/lint/lint: Add command line parsing ......................................................................
Patch Set 1:
(3 comments)
File util/lint/lint:
https://review.coreboot.org/c/coreboot/+/67191/comment/ec4bb1e6_bc4974ae PS1, Line 21: $(getopt -l help,junit -o hJ -- "$@") quotes
https://review.coreboot.org/c/coreboot/+/67191/comment/ae13665b_056a007e PS1, Line 25: if [ ${getopt_ret} -ne 0 ]; then You could do: ``` if ! cmd_args=$(getopt -l help,junit -o hJ -- "$@"); then ``` and avoid the ret variable
https://review.coreboot.org/c/coreboot/+/67191/comment/76ea2b9e_7817509e PS1, Line 51: [ nit: Add an extra indent so it doesn't look like it's part of the block