Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37911 )
Change subject: mb/google/kohaku: Set reset hold time for I2C digitizer device ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37911/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/37911/1/src/mainboard/google/hatch/... PS1, Line 213: post-power-on-delay-ms
Just curious: Is this better/different than setting "reset_delay_ms" to 100 above in line 209 above?
This looks like it will do the same thing as reset_delay, except not allow coordination with enable GPIOs, etc. Leaving it this way means that the ACPI _ON method will do the reset/enable GPIO sequence in common ACPI code, then when it gets to this driver, it will reset it again, without any regards for the enable GPIO sequencing.