Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47309 )
Change subject: mb/google/zork: Add func to determine fingerprint gpio init ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/c/coreboot/+/47309/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47309/2//COMMIT_MSG@9 PS2, Line 9: Because fingerprint sensor isn't a CBI field, it needs to be determined : by board and SKU.
I mentioned this in another message, but the decision was made not to add it, and a number of boards […]
Updated commit message based on other changes.
https://review.coreboot.org/c/coreboot/+/47309/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/47309/2/src/mainboard/google/zork/v... PS2, Line 34: int
I'll add a comment here.
Updated comment.
https://review.coreboot.org/c/coreboot/+/47309/2/src/mainboard/google/zork/v... PS2, Line 34: init
sounds good. will update.
Done
https://review.coreboot.org/c/coreboot/+/47309/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/variant.c:
https://review.coreboot.org/c/coreboot/+/47309/2/src/mainboard/google/zork/v... PS2, Line 10: if (ENV_RAMSTAGE) { : cfg = (struct soc_amd_picasso_config *)config_of_soc();
I think we should let the linker optimize things out rather than adding ENV_RAMSTAGE checks.
Done
https://review.coreboot.org/c/coreboot/+/47309/2/src/mainboard/google/zork/v... PS2, Line 21: BERKNIP_SKU0_ID 0x5A030020
Okay. […]
Sounds good. I'll update it to always enable fingerprint.