Evan Green has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43153 )
Change subject: mb/google/dedede: Add Goodix touchscreen
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43153/1/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/waddledee/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43153/1/src/mainboard/google/dedede...
PS1, Line 83: 14
Even after that observing "i2c_hid i2c-GDIX0000:00: failed to retrieve report from device. […]
got it. I got my device today so I may be able to take a look tomorrow. Maybe it just needs a FW update first.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43153
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55fc0749b824a0bf4b615d02bd8bc39bcdd589e0
Gerrit-Change-Number: 43153
Gerrit-PatchSet: 2
Gerrit-Owner: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 07 Jul 2020 23:54:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment