Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47877 )
Change subject: soc/amd/common: add comments and FIXME to Makefile.inc files ......................................................................
soc/amd/common: add comments and FIXME to Makefile.inc files
Change-Id: Ie347ee508acd900353467b4a3e0a5d1928b110e1 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/47877 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/common/block/pci/Makefile.inc M src/soc/amd/common/block/pi/Makefile.inc M src/soc/amd/common/block/s3/Makefile.inc M src/soc/amd/common/block/smbus/Makefile.inc 4 files changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/soc/amd/common/block/pci/Makefile.inc b/src/soc/amd/common/block/pci/Makefile.inc index baebb6c..1fed96e 100644 --- a/src/soc/amd/common/block/pci/Makefile.inc +++ b/src/soc/amd/common/block/pci/Makefile.inc @@ -1,6 +1,6 @@ - ramstage-$(CONFIG_SOC_AMD_COMMON_BLOCK_PCI) += amd_pci_util.c
+# FIXME: This gets added when CONFIG_SOC_AMD_COMMON is set, which is a bit unexpected. bootblock-y += amd_pci_mmconf.c verstage_x86-y += amd_pci_mmconf.c romstage-y += amd_pci_mmconf.c diff --git a/src/soc/amd/common/block/pi/Makefile.inc b/src/soc/amd/common/block/pi/Makefile.inc index 5afbb3e..7b5d73a 100644 --- a/src/soc/amd/common/block/pi/Makefile.inc +++ b/src/soc/amd/common/block/pi/Makefile.inc @@ -14,4 +14,4 @@ ramstage-y += image.c ramstage-y += refcode_loader.c
-endif +endif # CONFIG_SOC_AMD_COMMON_BLOCK_PI diff --git a/src/soc/amd/common/block/s3/Makefile.inc b/src/soc/amd/common/block/s3/Makefile.inc index 9efc6bc..03395ec 100644 --- a/src/soc/amd/common/block/s3/Makefile.inc +++ b/src/soc/amd/common/block/s3/Makefile.inc @@ -3,4 +3,4 @@ romstage-y += s3_resume.c ramstage-y += s3_resume.c
-endif +endif # CONFIG_SOC_AMD_COMMON_BLOCK_S3 diff --git a/src/soc/amd/common/block/smbus/Makefile.inc b/src/soc/amd/common/block/smbus/Makefile.inc index cfc954e..b9c7f2a 100644 --- a/src/soc/amd/common/block/smbus/Makefile.inc +++ b/src/soc/amd/common/block/smbus/Makefile.inc @@ -4,4 +4,4 @@ ramstage-y += smbus.c ramstage-y += sm.c
-endif +endif # CONFIG_SOC_AMD_COMMON_BLOCK_SMBUS