Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33552 )
Change subject: mb/google/octopus: Override DDI1 DDC SDA/SCL for Garg HDMI
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/33552/2/src/mainboard/google/octopus/variant...
File src/mainboard/google/octopus/variants/garg/gpio.c:
https://review.coreboot.org/#/c/33552/2/src/mainboard/google/octopus/variant...
PS2, Line 29: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_127, NONE, DEEP, NF1, HIZCRx1,
if you have external PU, the internal PU is just to make the PU capability stronger. […]
Thanks Kane.
Hi Marco, since we already have external PU 2.2K and it's strong enough to have 3.3V PU.
is it ok to you? thank you!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33552
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6ad8e5aa52f503121b10fe353e4bf4021aee2061
Gerrit-Change-Number: 33552
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Keith Tzeng
keith.tzeng@quantatw.com
Gerrit-Reviewer: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Kevin Chiu
kevin.chiu@quanta.corp-partner.google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kane Chen
kane.chen@intel.com
Gerrit-Comment-Date: Tue, 18 Jun 2019 09:12:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marco Chen
marcochen@google.com
Comment-In-Reply-To: Kane Chen
kane.chen@intel.com
Comment-In-Reply-To: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-MessageType: comment