[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/gpio_defs: Add a macro for EDGE_BOTH trigger pad

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48302 )

Change subject: soc/intel/common/gpio_defs: Add a macro for EDGE_BOTH trigger pad
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48302/3/src/soc/intel/common/block/... 
File src/soc/intel/common/block/include/intelblocks/gpio_defs.h:

https://review.coreboot.org/c/coreboot/+/48302/3/src/soc/intel/common/block/... 
PS3, Line 276: ,
> Thanks for your comment. I will try it. […]

I think it is just a miss. We should not rely on the trigger being configured in coreboot and just set it to off. Kernel is responsible for configuring the interrupts and it should set up the trigger correctly. I think it is okay to update the same macro to set PAD_TRIG(OFF) rather than creating a new macro (Reason is that more macros = more confusion and in this case the right thing to do is keep trigger off).