Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32421 )
Change subject: nb/amd/pi: support for boards without BINARYPI_LEGACY_WRAPPER
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/32421/5/src/northbridge/amd/pi/stat...
File src/northbridge/amd/pi/state_machine.c:
https://review.coreboot.org/c/coreboot/+/32421/5/src/northbridge/amd/pi/stat...
PS5, Line 5: * Copyright (C) 2019 3mdeb Embedded Systems Consulting
I don't think you changed the file at all? Line removals don't count. Anyways, these copyright lines are being yanked anyways.
This goes into per-family directory. There are some minor differences in AGESA headers and implementations why I want to do it that way.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32421
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I700a7d8d3c77ee0525b2c764c720ab5bf39925f8
Gerrit-Change-Number: 32421
Gerrit-PatchSet: 5
Gerrit-Owner: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 23 Nov 2019 19:31:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment