Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44782 )
Change subject: fw_config: Add caching to successfully probed fields ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44782/3/src/include/fw_config.h File src/include/fw_config.h:
https://review.coreboot.org/c/coreboot/+/44782/3/src/include/fw_config.h@48 PS3, Line 48: void fw_config_for_each_found(void (*cb)(const struct fw_config *config, void *arg), void *arg);
Yeah, they're small functions, how about I just leave both of them here.
Done
https://review.coreboot.org/c/coreboot/+/44782/3/src/lib/fw_config.c File src/lib/fw_config.c:
https://review.coreboot.org/c/coreboot/+/44782/3/src/lib/fw_config.c@91 PS3, Line 91: return __ffs(probe->mask);
The constants intended to be used here are generated in static. […]
Done
https://review.coreboot.org/c/coreboot/+/44782/4/src/lib/fw_config.c File src/lib/fw_config.c:
https://review.coreboot.org/c/coreboot/+/44782/4/src/lib/fw_config.c@85 PS4, Line 85: mask
There is a comment in the . […]
Done