HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39614 )
Change subject: sc7180: Add display dsi interface programming [Patch 2 of 3] ......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39614/16/src/soc/qualcomm/sc7180/di... File src/soc/qualcomm/sc7180/display/target_sc7180.c:
https://review.coreboot.org/c/coreboot/+/39614/16/src/soc/qualcomm/sc7180/di... PS16, Line 15: : #include <device/mmio.h> : #include <lib.h> : #include <console/console.h> : #include <delay.h> : #include <device/device.h> : #include <edid.h> : #include <stdlib.h> : #include <string.h> : #include <soc/display/panel.h> : #include <soc/display/msm_panel.h> : #include <soc/display/mdssreg.h> : #include <soc/display/mipi_dsi.h> : #include <soc/display/panel_display.h> : #include <soc/display/target_sc7180.h> : #include <gpio.h> : #include <soc/gpio.h> please include only what you use