Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46389 )
Change subject: soc/mediatek/mt8192: add spmfw loader ......................................................................
Patch Set 37:
(5 comments)
https://review.coreboot.org/c/coreboot/+/46389/35/src/soc/mediatek/mt8192/Kc... File src/soc/mediatek/mt8192/Kconfig:
https://review.coreboot.org/c/coreboot/+/46389/35/src/soc/mediatek/mt8192/Kc... PS35, Line 49: "The file name of the MediaTek SPM firmware"
You don't need to add this (unless if you want to allow developers overriding that when 'make menu'; […]
Done
https://review.coreboot.org/c/coreboot/+/46389/36/src/soc/mediatek/mt8192/Ma... File src/soc/mediatek/mt8192/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/46389/36/src/soc/mediatek/mt8192/Ma... PS36, Line 53: mcu-firmware-files := $(CONFIG_SPM_FIRMWARE)
The later […]
Done
https://review.coreboot.org/c/coreboot/+/46389/35/src/soc/mediatek/mt8192/sp... File src/soc/mediatek/mt8192/spm.c:
https://review.coreboot.org/c/coreboot/+/46389/35/src/soc/mediatek/mt8192/sp... PS35, Line 436: 0x40000000
Ok. I'll name it in the next patch.
Done
https://review.coreboot.org/c/coreboot/+/46389/35/src/soc/mediatek/mt8192/sp... PS35, Line 443: BIOS_INFO
Ok. I'll change it to DEBUG.
Done
https://review.coreboot.org/c/coreboot/+/46389/35/src/soc/mediatek/mt8192/sp... PS35, Line 453: if (read32(&mtk_spm->md32pcm_dma0_src) != ptr || : read32(&mtk_spm->md32pcm_dma0_dst) != pmem_start || : read32(&mtk_spm->md32pcm_dma0_wppt) != pmem_words || : read32(&mtk_spm->md32pcm_dma0_wpto) != dmem_start || : read32(&mtk_spm->md32pcm_dma0_count) != total_words || : read32(&mtk_spm->md32pcm_dma0_con) != MD32PCM_DMA0_CON_VAL) {
Okay, I see. Let's do "always kick IM to refetch". I'll update it in the next patch.
Done