Attention is currently required from: Jamie Ryu, Subrata Banik, Ethan Tsao, Ravishankar Sarawadi, Tim Wawrzynczak, Paul Menzel, Angel Pons, Nick Vaccaro. Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63198 )
Change subject: soc/intel/common: implement ioc driver ......................................................................
Patch Set 8:
(9 comments)
File src/soc/intel/common/block/include/intelblocks/ioc.h:
https://review.coreboot.org/c/coreboot/+/63198/comment/26380ed0_26c8ea52 PS5, Line 10: <soc/ioc_reg.h>
I'll remove this option for now. […]
Ack
https://review.coreboot.org/c/coreboot/+/63198/comment/5645d3b0_7c3be2a7 PS5, Line 12: /*
nit: Add space after comment beginning
Ack
https://review.coreboot.org/c/coreboot/+/63198/comment/e2fa77bb_ed06dc2e PS5, Line 15: : void ioc_reg_write32(uint32_t offset, uint32_t value); : uint32_t ioc_reg_read32(uint32_t offset);
outside gpmr. […]
updated code to use gpmr api in other drivers and ioc api will be used in gpmr driver.
File src/soc/intel/common/block/include/intelblocks/ioc_reg.h:
https://review.coreboot.org/c/coreboot/+/63198/comment/58a28d0c_d11424a4 PS5, Line 7: A
Please use lowercase for hex
Ack
https://review.coreboot.org/c/coreboot/+/63198/comment/e3668c36_6d490cfb PS5, Line 8: C
Ditto
Ack
https://review.coreboot.org/c/coreboot/+/63198/comment/6eb03c72_e0eab27d PS5, Line 13: FFE
Ditto
Ack
https://review.coreboot.org/c/coreboot/+/63198/comment/4bdd5d89_be8f12d7 PS5, Line 14: A7C
Ditto
Ack
https://review.coreboot.org/c/coreboot/+/63198/comment/2b27313a_f4f38351 PS5, Line 15: A
Ditto
Ack
File src/soc/intel/common/block/ioc/Kconfig:
https://review.coreboot.org/c/coreboot/+/63198/comment/9a581d32_2a149e85 PS5, Line 1: SOC_INTEL_COMMON_BLOCK_IOC
you are depending on MCH_BASE_ADDRESS being programmed for IOC read/write, hence, required driver is […]
Do we have KConfig for this?