EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46566 )
Change subject: mb/google/zork: Add explicit check for non-zero return value of cbi functions
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46566/7//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46566/7//COMMIT_MSG@10
PS7, Line 10: called
Present tense: call
Done
https://review.coreboot.org/c/coreboot/+/46566/7//COMMIT_MSG@9
PS7, Line 9: Since google_chromeec_cbi_get_board_version and
: google_chromeec_cbi_get_fw_config both called cbi_get_unit32 and
: return 0 as success.
The sentence should continue somehow?
I didn't get you.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46566
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia49ac1ee35302f8f6afe8c0eb8e13afdf36c5b2b
Gerrit-Change-Number: 46566
Gerrit-PatchSet: 8
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 21 Oct 2020 11:40:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment