Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36839 )
Change subject: soc/intel/icelake: Make CpuMpPpi implementation default for ICL
......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
Not for now. If someone just implements it publicly as open-source solution we can undo the changes
I guess the problem is that, some CPU programming has to be performed between FSP calls so until entire FSP-S is not open source i guess this going to be our only solution :(
In what sense does it has to be performed between FSP calls? Can it be implemented in coreboot, but Intel wants to hide some of the details in FSP (or is not interested in doing it in open source code for other reasons) or does FSP have an artificial reliance on being able to CPU programming itself. If the latter is the case, please document it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36839
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd71ec99f06434896c73cff5a52cd3a5ad6ce5f3
Gerrit-Change-Number: 36839
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Comment-Date: Fri, 15 Nov 2019 11:42:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment