build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31173 )
Change subject: google/mistral: Support triggering Recovery/FDR
......................................................................
Patch Set 28:
(1 comment)
https://review.coreboot.org/c/coreboot/+/31173/28/src/mainboard/google/mistr...
File src/mainboard/google/mistral/verstage.c:
https://review.coreboot.org/c/coreboot/+/31173/28/src/mainboard/google/mistr...
PS28, Line 29: if (spi_setup_slave(CONFIG_DRIVER_TPM_SPI_BUS, CONFIG_DRIVER_TPM_SPI_CHIP, &spi)) {
braces {} are not necessary for single statement blocks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31173
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifdbd696ee3fd9f073cc44a49ad341cad7e33845e
Gerrit-Change-Number: 31173
Gerrit-PatchSet: 28
Gerrit-Owner: SANTHOSH JANARDHANA HASSAN
sahassan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nitheesh Sekar
nsekar@codeaurora.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: SANTHOSH JANARDHANA HASSAN
sahassan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 12 Aug 2019 16:04:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment