Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33129 )
Change subject: soc/intel/common/block: Enable PCH Thermal Sensor for threshold configuration ......................................................................
Patch Set 18:
(6 comments)
https://review.coreboot.org/c/coreboot/+/33129/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33129/3//COMMIT_MSG@7 PS3, Line 7: soc/intel/cannonlake: Set correct temperature threshold for PCH Thermal Sensor
s/Set correct/correct/ is shorter.
Done
https://review.coreboot.org/c/coreboot/+/33129/3/src/soc/intel/cannonlake/th... File src/soc/intel/cannonlake/thermal.c:
https://review.coreboot.org/c/coreboot/+/33129/3/src/soc/intel/cannonlake/th... PS3, Line 27: #define MAX_TRIP_TEMP 205
I will add below comment for this define. […]
Done
https://review.coreboot.org/c/coreboot/+/33129/3/src/soc/intel/cannonlake/th... PS3, Line 28: #define DEFAULT_TRIP_TEMP 50
This is the safest Trip Temp value.
Done
https://review.coreboot.org/c/coreboot/+/33129/7/src/soc/intel/cannonlake/th... File src/soc/intel/cannonlake/thermal.c:
https://review.coreboot.org/c/coreboot/+/33129/7/src/soc/intel/cannonlake/th... PS7, Line 54: = dev->chip_info; : : if (!config) { : printk(BIOS_ERR, "PCH thermal config not found!\n"); : return 0; : } :
Sure. ACK.
Done
https://review.coreboot.org/c/coreboot/+/33129/9/src/soc/intel/cannonlake/th... File src/soc/intel/cannonlake/thermal.c:
https://review.coreboot.org/c/coreboot/+/33129/9/src/soc/intel/cannonlake/th... PS9, Line 89: PCH
Sure.
Done
https://review.coreboot.org/c/coreboot/+/33129/12/src/soc/intel/common/pch/t... File src/soc/intel/common/pch/thermal/thermal.c:
https://review.coreboot.org/c/coreboot/+/33129/12/src/soc/intel/common/pch/t... PS12, Line 89:
or you can also create a helper function like below […]
Done