Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47235 )
Change subject: drivers/i2c/rx6110sa: Add basic ACPI support ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/47235/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47235/5//COMMIT_MSG@11 PS5, Line 11:
The Linux driver patch should output the following dmesg message: […]
Paul, do you want me to add these lines to the commit message?
https://review.coreboot.org/c/coreboot/+/47235/5/src/drivers/i2c/rx6110sa/rx... File src/drivers/i2c/rx6110sa/rx6110sa.c:
https://review.coreboot.org/c/coreboot/+/47235/5/src/drivers/i2c/rx6110sa/rx... PS5, Line 176: !dev->enabled
CB:47148 made this check unnecessary
Oh, I was not aware of this change, thank you. I will remove this check here.
https://review.coreboot.org/c/coreboot/+/47235/5/src/drivers/i2c/rx6110sa/rx... PS5, Line 185: printk(BIOS_WARNING, "%s: Unsupported bus speed in devicetree!\n",
Please extend the message tro mention, that it falls back to standard speed.
I had that in the first place but the line got really long. Will think about a shorter way and add the hint.
https://review.coreboot.org/c/coreboot/+/47235/5/src/drivers/i2c/rx6110sa/rx... PS5, Line 215: BIOS_INFO
nit: I'd use BIOS_DEBUG
I would rather go with BIOS_INFO then as BIOS_DEBUG produces a large output where things get lost easily.