[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Steal no memory for disabled IGD

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39454 )

Change subject: soc/intel/cannonlake: Steal no memory for disabled IGD
......................................................................

Patch Set 12:

(3 comments)

https://review.coreboot.org/c/coreboot/+/39454/8/src/soc/intel/cannonlake/ro... 
File src/soc/intel/cannonlake/romstage/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/39454/8/src/soc/intel/cannonlake/ro... 
PS8, Line 38: dev
> See other message.

Done

https://review.coreboot.org/c/coreboot/+/39454/8/src/soc/intel/cannonlake/ro... 
PS8, Line 38: 			(dev && (pci_read_config16(SA_DEV_IGD, PCI_VENDOR_ID) == 0xffff))) {
> Explained in a comment.

Patrick, do you mean to add a comment to the code?

https://review.coreboot.org/c/coreboot/+/39454/8/src/soc/intel/cannonlake/ro... 
PS8, Line 163: 		tconfig->PanelPowerEnable = 0;
> https://github.com/IntelFsp/FSP/issues/49 […]

Thank you for updating the commit message.