build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38548 )
Change subject: Add Intel SkyLake Scalable Processor support ......................................................................
Patch Set 6:
(88 comments)
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/ch... File src/soc/intel/skylake_sp/chip.c:
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/ch... PS6, Line 393: /* for 1st time update, overlading IORESOURCE_ASSIGNED */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/ch... PS6, Line 394: if (!(bridge->flags & IORESOURCE_ASSIGNED)) { Too many leading tabs - consider code refactoring
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/ch... PS6, Line 398: } else { Too many leading tabs - consider code refactoring
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/ch... PS6, Line 399: /* update bridge range from child bridge range */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/ch... PS6, Line 400: if (res->base < bridge->base) Too many leading tabs - consider code refactoring
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/ch... PS6, Line 402: if (res->limit > bridge->limit) Too many leading tabs - consider code refactoring
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/ch... PS6, Line 405: bridge->size = (bridge->limit - bridge->base + 1); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/ch... PS6, Line 407: __func__, resource_type(res), bridge->base, bridge->size, bridge->limit); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... File src/soc/intel/skylake_sp/include/soc/hob_iiouds.h:
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 47: UINT8 Valid; // TRUE, if the link is valid (i.e reached normal operation) line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 55: UINT8 SocketFirstBus; line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 56: UINT8 SocketLastBus; line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 57: UINT8 segmentSocket; line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 58: UINT8 PcieSegment; line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 60: UINT8 stackPresentBitmap; line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 61: UINT8 StackBus[MAX_IIO_STACK]; line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 62: UINT8 M2PciePresentBitmap; line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 63: UINT8 TotM3Kti; line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 67: QPI_PEER_DATA PeerInfo[MAX_KTI_PORTS]; // QPI LEP info line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 73: QPI_PEER_DATA PeerInfo[MAX_SOCKET]; // QPI LEP info line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 84: UINT16 PciResourceIoBase; line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 85: UINT16 PciResourceIoLimit; line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 88: UINT32 PciResourceMem32Base; line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 89: UINT32 PciResourceMem32Limit; line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 90: UINT64 PciResourceMem64Base; line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 91: UINT64 PciResourceMem64Limit; line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 100: UINT16 PciResourceIoBase; line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 101: UINT16 PciResourceIoLimit; line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 104: UINT32 PciResourceMem32Base; line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 105: UINT32 PciResourceMem32Limit; line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 106: UINT64 PciResourceMem64Base; line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 107: UINT64 PciResourceMem64Limit; line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 108: STACK_RES StackRes[MAX_IIO_STACK]; line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 131: UINT32 packageBspApicID[MAX_SOCKET]; // This data array is valid only for SBSP, not for non-SBSP CPUs. <AS> for CpuSv line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 140: UINT64 softskuSocketPresentBitMap; // bitmap of Softsku sockets with CPUs present detected line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 141: BOOLEAN Simics; // TRUE - Simics Environtment; FALSE - H\w line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 146: UINT8 CurrentCsiLinkSpeed;// Current programmed CSI Link speed (Slow/Full speed mode) line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 147: UINT8 CurrentCsiLinkFrequency; // Current requested CSI Link frequency (in GT) line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 148: UINT32 OutKtiPerLinkL1En[MAX_SOCKET]; // output kti link enabled status for PM line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 150: UINT32 meRequestedSize; // Size of the memory range requested by ME FW, in MB line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 160: UINT8 numCpus; // 1,..4. Total number of CPU packages installed and detected (1..4)by QPI RC line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 161: UINT32 FusedCores[MAX_SOCKET]; ///< Fused Core Mask in the package line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 162: UINT32 ActiveCores[MAX_SOCKET];// Current activated core Mask in the package line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 163: UINT8 MaxCoreToBusRatio[MAX_SOCKET]; // Package Max Non-turbo Ratio (per socket). line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 164: UINT8 MinCoreToBusRatio[MAX_SOCKET]; // Package Maximum Efficiency Ratio (per socket). line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 165: UINT8 CurrentCoreToBusRatio; // Current system Core to Bus Ratio line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 166: UINT32 IntelSpeedSelectCapable; // ISS Capable (system level) Bit[7:0] and current Config TDP Level Bit[15:8] line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 167: UINT32 IssConfigTdpLevelInfo; // get B2P CONFIG_TDP_GET_LEVELS_INFO line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 168: UINT32 IssConfigTdpTdpInfo[CONFIG_TDP_MAX_LEVEL]; // get B2P CONFIG_TDP_GET_TDP_INFO line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 169: UINT32 IssConfigTdpPowerInfo[CONFIG_TDP_MAX_LEVEL]; // get B2P CONFIG_TDP_GET_POWER_INFO line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 170: UINT8 IssConfigTdpCoreCount[CONFIG_TDP_MAX_LEVEL]; // get B2P CONFIG_TDP_GET_CORE_COUNT line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 171: UINT32 socketPresentBitMap; // bitmap of sockets with CPUs present detected by QPI RC line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 172: UINT32 FpgaPresentBitMap; // bitmap of NID w/ fpga present detected by QPI RC line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... File src/soc/intel/skylake_sp/include/soc/hob_memmap.h:
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 244: UINT8 RasModesSupported; //RAS modes that are supported by current memory population. line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... File src/soc/intel/skylake_sp/include/soc/soc_util.h:
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 26: printk(BIOS_SPEW, "%s:%d res: %s, dev: %s, index: 0x%x, base: 0x%llx, end: 0x%llx, size_kb: 0x%llx\n", \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/in... PS6, Line 31: printk(BIOS_SPEW, "%s:%d res: %s, dev: %s, index: 0x%x, base: 0x%llx, end: 0x%llx, size: 0x%llx\n", \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... File src/soc/intel/skylake_sp/soc_util.c:
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 455: bus_no, device_no, function_no, vendor_id, device_id); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 458: device_no, function_no), (0x10 + (b * 4))); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 479: device_no, function_no), UNC_SOCKETID_UBOX_GID_OFFSET); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 482: if (nodeid == ((mapping >> (3 * i)) & 0x7)) { Too many leading tabs - consider code refactoring
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 492: * cpubusnos from (B: <above bus>, D:8, F:2, O:0xcc, 0xd0) line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 497: b1 = pci_mmio_read_config32(PCI_DEV(bus_no, 8, 2), 0xcc); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 498: b2 = pci_mmio_read_config32(PCI_DEV(bus_no, 8, 2), 0xd0); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 504: if (i == 0) Too many leading tabs - consider code refactoring
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 507: u32 start_busno = ((b1 >> (stack_id * 8)) & 0xff); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 509: stack_id, start_busno, (r >> (i * 8)) & 0xff); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 517: if (i == 0) Too many leading tabs - consider code refactoring
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 518: start_busno = ((b1 >> (stack_id * 8)) & 0xff); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 519: else Too many leading tabs - consider code refactoring
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 520: start_busno = ((b2 >> ((i-1) * 8)) & 0xff); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 522: stack_id, start_busno, (r >> (i * 8)) & 0xff); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 555: PCU_DEV, PCU_CR1_FUN), line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 556: PCU_CR1_BIOS_RESET_CPL_REG); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 560: (reg >> 9) & 0x1, (reg >> 10) & 0x1, (reg >> 11) & 0x1, (reg >> 12) & 0x1); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 562: (reg >> 1) & 0x1, (reg >> 2) & 0x1, (reg >> 3) & 0x1, (reg >> 4) & 0x1); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 628: (u32) (command | PCU_CR1_BIOS_MB_INTERFACE_REG_RUN_BUSY_BIT)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 650: (plat_info & MAX_NON_TURBO_LIM_RATIO_MASK) >> MAX_NON_TURBO_LIM_RATIO_SHIFT; line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 697: status = write_bios_mailbox_cmd(dev, PCU_CR1_BIOS_MB_CMD_WRITE_PCU_MISC_CONFIG, data); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 712: set_bios_reset_cpl_for_package(socket, 4, 12, 1); /* update RST_CPL3, PCODE_INIT_DONE3 */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 714: set_bios_reset_cpl_for_package(socket, 5, 13, 1); /* update RST_CPL4, PCODE_INIT_DONE4 */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 869: printk(BIOS_DEBUG, "\t\tpirq_reg: x%x, addr: 0x%p, val: 0x%x\n", reg, addr, val); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 916: if (ri->BusBase < ri->BusLimit) // TODO: do we have situation with only bux 0 and one stack? line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 932: if (ri->BusBase < ri->BusLimit) // TODO: do we have situation with only bux 0 and one stack? line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 1021: IA32_MISC_ENABLE, msr.hi, msr.lo, msr.lo, msr.hi, (msr.lo >> 18) & 0x1, line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 1022: (msr.lo & FAST_STRINGS_ENABLE_BIT), (msr.lo & SPEED_STEP_ENABLE_BIT)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 1061: MSR_PMG_IO_CAPTURE_BASE, msr.hi, msr.lo, msr.lo & 0xffff, (msr.lo >> 16) & 0x7); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 1214: (uint64_t) ((uint64_t)mem_element->BaseAddress << MEM_ADDR_64MB_SHIFT_BITS); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 1216: (uint64_t) ((uint64_t)mem_element->ElementSize << MEM_ADDR_64MB_SHIFT_BITS); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38548/6/src/soc/intel/skylake_sp/so... PS6, Line 1259: int fixed_msrs[] = {0x250, 0x258, 0x259, 0x268, 0x269, 0x26a, 0x26b, 0x26c, 0x26d, 0x26e, 0x26f}; line over 96 characters