Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35229 )
Change subject: src/soc/intel/common/block/cse: Add hmrfpo related functions to cse lib ......................................................................
Patch Set 17:
(7 comments)
https://review.coreboot.org/c/coreboot/+/35229/16//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35229/16//COMMIT_MSG@7 PS16, Line 7: inte
intel
Done
https://review.coreboot.org/c/coreboot/+/35229/16//COMMIT_MSG@9 PS16, Line 9: function
functions
Done
https://review.coreboot.org/c/coreboot/+/35229/16/src/soc/intel/common/block... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35229/16/src/soc/intel/common/block... PS16, Line 639: uint32_t nonce[2];
In client platforms, those are reserved fields.
Done
https://review.coreboot.org/c/coreboot/+/35229/16/src/soc/intel/common/block... PS16, Line 654: uint32_t fct_base; : uint32_t fct_limit;
Those are reserved fields in the client platforms.
Done
https://review.coreboot.org/c/coreboot/+/35229/16/src/soc/intel/common/block... PS16, Line 660: struct hmrfpo_enable_resp resp;
It must be here only due to structure "hmrfpo_enable_resp" declatration
Done
https://review.coreboot.org/c/coreboot/+/35229/16/src/soc/intel/common/block... PS16, Line 661: size_t resp_size
Not required!
Done
https://review.coreboot.org/c/coreboot/+/35229/16/src/soc/intel/common/block... PS16, Line 662: union me_hfsts1 hfs1;
Not required!
Done