Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39089 )
Change subject: soc/intel/skylake/elog: fix BUG: pch_log_rp_wake_source requests hidden ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39089/1/src/soc/intel/skylake/elog.... File src/soc/intel/skylake/elog.c:
https://review.coreboot.org/c/coreboot/+/39089/1/src/soc/intel/skylake/elog.... PS1, Line 52: pci_devfn_t dev)
I meant the parameter `dev` in this particular line.
Done
https://review.coreboot.org/c/coreboot/+/39089/2/src/soc/intel/skylake/elog.... File src/soc/intel/skylake/elog.c:
https://review.coreboot.org/c/coreboot/+/39089/2/src/soc/intel/skylake/elog.... PS2, Line 86: !val ||
What? not that it matters, but we don't have to check it explicitly.
Done
https://review.coreboot.org/c/coreboot/+/39089/2/src/soc/intel/skylake/elog.... PS2, Line 146: if (!dev) : continue;
this too
Done