[coreboot-gerrit] Change in coreboot[master]: soc/amd/common: Refactor SMBus base arguments

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42074 )

Change subject: soc/amd/common: Refactor SMBus base arguments
......................................................................

Patch Set 19: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/42074/17/src/soc/amd/common/block/s... 
File src/soc/amd/common/block/smbus/sm.c:

https://review.coreboot.org/c/coreboot/+/42074/17/src/soc/amd/common/block/s... 
PS17, Line 28: 	res = find_resource(pbus->dev, 0x90);
> AFAIR, I had a revert for the copy-paste of this file, but Marshall blocked it in Jan2020. […]

after thinking a bit about this, i'd say that the only useful solution here would be always returning (uintptr_t)acpimmio_smbus for this pci device and when someone wants/needs to access asf, they need to use a corresponding mmio device and not the pci device. this is out of scope for this patch though