Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40670 )
Change subject: arch/x86/acpigen: Add helpers for generating _ADR
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/40670/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40670/3//COMMIT_MSG@10
PS3, Line 10: acpigen_write_ADR: Generates _ADR object using provided 64-bit address
ACPI specification version 6.3 section 6.1. […]
Yes, thank you. I read "64-bit address" and subconsciously implied a
memory address, that's where I stumbled.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40670
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I139dfc30aa7db303c1e8bd4a8f9ee0933a60139b
Gerrit-Change-Number: 40670
Gerrit-PatchSet: 4
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 27 Apr 2020 08:17:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment