Attention is currently required from: Raul Rangel, Furquan Shaikh, Karthik Ramasubramanian.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56581 )
Change subject: device/pci_rom: Add vga_oprom_preload
......................................................................
Patch Set 9: Code-Review+1
(1 comment)
File src/device/pci_rom.c:
https://review.coreboot.org/c/coreboot/+/56581/comment/48b78cd6_99793361
PS9, Line 28: printk(BIOS_DEBUG, "Preloading VGA ROM\n");
nit: printing name here would be helpful for debugging.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56581
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icb54fe3a942e9507ff6f1173ba5620a8f4ce6549
Gerrit-Change-Number: 56581
Gerrit-PatchSet: 9
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 05 Nov 2021 15:20:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment