Łukasz Siudut has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31525 )
Change subject: mb/ocp/monolake: add TPM and IPMI support ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31525/1/src/mainboard/ocp/monolake/romstage.... File src/mainboard/ocp/monolake/romstage.c:
https://review.coreboot.org/#/c/31525/1/src/mainboard/ocp/monolake/romstage.... PS1, Line 32: 0x0c0ca1);
0x0ca0 is used by the IPMI.
This is exactly why it is here - to make IPMI accessible.
https://review.coreboot.org/#/c/31525/1/src/mainboard/ocp/monolake/romstage.... PS1, Line 33: pci_write_config32(PCI_DEV(0, LPC_DEV, LPC_FUNC), LPC_GEN3_DEC,
what are the other entries good for ? […]
To be perfectly honest I just copied them from UEFI system. There are similar entries for other platforms, also undocumented, that's why I decided to braindead copy it. I'm ok with removing them though. Don't know what's a good practice here.