Venkata Krishna Nimmagadda has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41800 )
Change subject: soc/intel/tigerlake/acpi: Update gpio_op.asl to ASL2.0 syntax
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/41800/1/src/soc/intel/tigerlake/acp...
File src/soc/intel/tigerlake/acpi/gpio_op.asl:
https://review.coreboot.org/c/coreboot/+/41800/1/src/soc/intel/tigerlake/acp...
PS1, Line 79: Local0 = VAL0
: Local0 = ~PAD_CFG0_MODE_MASK & Local0
could combine this to just […]
Ack
https://review.coreboot.org/c/coreboot/+/41800/1/src/soc/intel/tigerlake/acp...
PS1, Line 81: >>
<< ?
Thanks for pointing.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41800
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib54b3f7da828ce8d232fcea0639077970638f610
Gerrit-Change-Number: 41800
Gerrit-PatchSet: 2
Gerrit-Owner: Venkata Krishna Nimmagadda
Venkata.krishna.nimmagadda@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Venkata Krishna Nimmagadda
Venkata.krishna.nimmagadda@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-Comment-Date: Mon, 01 Jun 2020 16:30:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Gerrit-MessageType: comment