Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36136 )
Change subject: soc/intel: skl,cnl,icl: rely on TOLUM as cbmem_top returned by FSP
......................................................................
Patch Set 10: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/36136/10/src/soc/intel/skylake/memm...
File src/soc/intel/skylake/memmap.c:
https://review.coreboot.org/c/coreboot/+/36136/10/src/soc/intel/skylake/memm...
PS10, Line 73: die("9.3: FSP_BOOTLOADER_TOLUM_HOB missing!\n");
Should we maybe move this into fsp_find_bootloader_tolum()? Is there
any call where we wouldn't want to die()?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36136
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If66a00d1320917bc68afb32c19db0e24c6732812
Gerrit-Change-Number: 36136
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Tue, 22 Oct 2019 21:50:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment