Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun, Tim Crawford.
Nico Huber has posted comments on this change by Tim Crawford. ( https://review.coreboot.org/c/coreboot/+/82729?usp=email )
Change subject: soc/intel/mtl: Hook up GMA ACPI brightness controls
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/soc/intel/meteorlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/82729/comment/412b07a0_3d9b902c?usp... :
PS2, Line 398: INTEL_GMA_BCLV_OFFSET
I've added CB:84224 to use it for system76/mtl.
It's used in the defalt ASL code, and technically already hooked up :)
src/mainboard/system76/mtl/acpi/backlight.asl:#include <drivers/intel/gma/acpi/gma.asl>
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82729?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ied08e5e9fe4913bd60474ed7dcf88b945172558d
Gerrit-Change-Number: 82729
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Wed, 11 Sep 2024 21:50:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Crawford
tcrawford@system76.com
Comment-In-Reply-To: Dinesh Gehlot
digehlot@google.com