Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37814 )
Change subject: soc/intel/common/block/acpi: Change Processor ACPI Name ......................................................................
Patch Set 7:
(6 comments)
https://review.coreboot.org/c/coreboot/+/37814/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37814/5//COMMIT_MSG@7 PS5, Line 7: src/soc/intel/common/block/acpi: Change Processor ACPI Name
Please remove `src/` from the prefix.
Ack
https://review.coreboot.org/c/coreboot/+/37814/5//COMMIT_MSG@11 PS5, Line 11: has been
present tense: is removed
Ack
https://review.coreboot.org/c/coreboot/+/37814/5//COMMIT_MSG@12 PS5, Line 12:
Is there some complaint by Linux, or how did you notice this?
Firmware Test Suite did throw an error thus I started investigating this.
https://review.coreboot.org/c/coreboot/+/37814/4/src/arch/x86/Kconfig File src/arch/x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/37814/4/src/arch/x86/Kconfig@289 PS4, Line 289: the acpigen function. Default is _PR.CPxx. Note that you need
Should _PR. […]
That would also be possible - the difference is only in the generated ACPI code. I like the scope approach better.
https://review.coreboot.org/c/coreboot/+/37814/4/src/soc/intel/common/block/... File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/37814/4/src/soc/intel/common/block/... PS4, Line 439: /* Generate processor _PR.CPUx */
needs update
Ack
https://review.coreboot.org/c/coreboot/+/37814/4/src/soc/intel/common/block/... PS4, Line 440: acpigen_write_processor
Processor () is deprecated. […]
Processor is deprecated since 6.0 - I would rather be compatible with ACPI Spec 2.0+ instead of jumping to 6.0