Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44192 )
Change subject: mb/google/zork: Switch USI_RESET to active low polarity for v3.6+ ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44192/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/ramstage_common.c:
https://review.coreboot.org/c/coreboot/+/44192/2/src/mainboard/google/zork/v... PS2, Line 213: if (variant_uses_v3_6_schematics())
You should probably add a comment that the rest of the function is for pre v3. […]
Done
https://review.coreboot.org/c/coreboot/+/44192/2/src/mainboard/google/zork/v... PS2, Line 224: mmio_dev
mmio_dev can be NULL here.
Done
https://review.coreboot.org/c/coreboot/+/44192/2/src/mainboard/google/zork/v... PS2, Line 231: child->chip_info
Could use config_of(child)
Done