Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37263 )
Change subject: mb/google: Add ALIGNED flag to known sections that need alignment
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37263/5/src/mainboard/google/auron/...
File src/mainboard/google/auron/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/37263/5/src/mainboard/google/auron/...
PS5, Line 7: RW_SECTION_A@0x0 0xf0000 {
The point is that it is never safe to have a section unaligned when
it needs to be updated independently
I see your point. My assumption was that, updating under flashrom is more safer, since those sections were designed with vboot in mind so we have so many mechanism to prevent corruption or failure. But yes, if A/B shares same block then we will have trouble.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37263
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6aacf6265f552e3190782dd9a78e0612b8c3a55
Gerrit-Change-Number: 37263
Gerrit-PatchSet: 6
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 28 Nov 2019 03:07:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment