Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44007 )
Change subject: mb/google/zork: add USB over-current pin mapping to devicetree ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44007/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44007/1/src/mainboard/google/zork/v... PS1, Line 26: register "usb_port_overcurrent_pin[0]" = "USB_OC_PIN_0" # USB C0
Can this be added to drivers_usb_acpi_config?
it probably could, but it would make things much more complicated since the setup of the OC pins isn't related to the ACPI tables or the generic XHCI driver, but is a very SoC specific thing, that gets passed via the FSP-S UPD. Might be that the ACPI ALIB thing, that is currently passed from FSP to coreboot via a HOB, has some overcurrent-related stuff inside; never looked too closely into how that table gets made