Aaron Durbin (adurbin@google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2885
-gerrit
commit 4ebb501ac903db8585e0caa6534240c1e9873d48 Author: Aaron Durbin adurbin@chromium.org Date: Fri Mar 22 20:23:17 2013 -0500
x86: mark .textfirst as allocatable and executable
When the linking of ramstage was changed to use an intermeidate object with all ramstage objects in it the .textfirst section was introduced to keep the entry point at 0. However, the section was not marked allocatable or executable. Nor was it marked as @progbits. That didn't cause an issue on its own since .textfirst was directly called out in the linker script. However, the rmodule infrastructure relies on all the relocation entries being included in the rmodule. Without the proper section attributes the .rel.textfirst section entries were not being included in the final ramstage rmodule.
Change-Id: I54e7055a19bee6c86e269eba047d9a560702afde Signed-off-by: Aaron Durbin adurbin@chromium.org --- src/arch/x86/lib/c_start.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/arch/x86/lib/c_start.S b/src/arch/x86/lib/c_start.S index 762aa8c..32af0cc 100644 --- a/src/arch/x86/lib/c_start.S +++ b/src/arch/x86/lib/c_start.S @@ -11,7 +11,7 @@ _stack: .space CONFIG_MAX_CPUS*CONFIG_STACK_SIZE _estack:
- .section ".textfirst" + .section ".textfirst", "ax", @progbits .code32 .globl _start _start: