William Wei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42677 )
Change subject: soc/intel/tigerlake: Run pmc_set_acpi_mode() during .init in pmc_ops
......................................................................
Patch Set 5:
Patch Set 5:
Hi William,
"firmware_FwScreenCloseLid" FAFT Test is failing in Jasperlake as well.
So i tried to port this CL to JSL and gave a try.
But still this test is failing with below error in Jasperlake.
Error: “Should shut the device down after calling wait_fw_screen_and_close_lid.”
Could you please help understand, how this CL is explicitly helping to solve the firmware_FwScreenCloseLid FAFT issue in TGL?
Lid close will generate a SMI event to make the DUT shutdown, but the condition is Chrome EC host event SMI mask bit not 0. pmc_set_acpi_mode() function will set Chrome EC SMI mask to 0x01, but it will be cleared to 0x00 during google_chromeec_events_init(), so LID close during fw_screen, Chrome EC won't send SMI to host to make the DUT shutdown.
This CL will delay the pmc_set_acpi_mode() function after google_chromeec_events_init(). Details please kindly refer to https://partnerissuetracker.corp.google.com/issues/153249055#comment125.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42677
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icfff5cc5550f23938343e4d26ef76093bb9cf7c3
Gerrit-Change-Number: 42677
Gerrit-PatchSet: 5
Gerrit-Owner: William Wei
wenxu.wei@bitland.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: William Wei
wenxu.wei@bitland.corp-partner.google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Magf -
magf@bitland.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Usha P
usha.p@intel.com
Gerrit-CC: Xiong Huang
xiong.huang@bitland.corp-partner.google.com
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Sun, 28 Jun 2020 01:50:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment