Attention is currently required from: Ravi kumar.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45205 )
Change subject: sc7280: Provide initial SoC support
......................................................................
Patch Set 22:
(1 comment)
File src/soc/qualcomm/sc7280/qclib.c:
https://review.coreboot.org/c/coreboot/+/45205/comment/64523918_687877c2
PS22, Line 28: /* Attempt to load Limits Config Blob */
: ssize = fmap_read_area(QCLIB_FR_LIMITS_CFG_DATA, _limits_cfg,
: REGION_SIZE(limits_cfg));
: if (ssize < 0)
: return -1;
: qclib_add_if_table_entry(QCLIB_TE_LIMITS_CFG_DATA,
: _limits_cfg, ssize, 0);
This is not in the sc7180 soc code. From talking to Juilus, it seemed like it was removed in the previous generation. Can you briefly explain what this blob does and why we need it in the sc7280 soc?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45205
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1fc841b3113f2bf79b8376cd1ccdb671c53c2084
Gerrit-Change-Number: 45205
Gerrit-PatchSet: 22
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Shelley Chen
shchen@google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Comment-Date: Thu, 14 Jan 2021 23:45:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment