Attention is currently required from: Julius Werner, Angel Pons.
Alex James has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60233 )
Change subject: util/cbfstool: Replace swab.h with commonlib/bsd/sysincludes.h
......................................................................
Patch Set 9:
(2 comments)
File util/cbfstool/cbfs_image.c:
https://review.coreboot.org/c/coreboot/+/60233/comment/eac08ee0_85108efa
PS6, Line 528: uint32_t type = htobe32(cur->type);
:
: /* Current entry is empty. Kepp track of it. */
: if ((type == htobe32(CBFS_TYPE_NULL)) ||
: (type == htobe32(CBFS_TYPE_DELETED))) {
Feel free to fix it if you want to... […]
Will do, thanks for reviewing!
https://review.coreboot.org/c/coreboot/+/60233/comment/5998c134_94e3b3c7
PS6, Line 1031: be32toh(stage->loadaddr)
My mistake (from CB:46484), thanks for catching! Please fix it while we're here.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60233
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54195865ab4042fcf83609fcf67ef8f33994d68e
Gerrit-Change-Number: 60233
Gerrit-PatchSet: 9
Gerrit-Owner: Alex James
theracermaster@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 31 Dec 2021 00:11:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Alex James
theracermaster@gmail.com
Gerrit-MessageType: comment