[coreboot-gerrit] Change in coreboot[master]: mb/google/asurada: Configure pins mode for SD

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47008 )

Change subject: mb/google/asurada: Configure pins mode for SD
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47008/1/src/mainboard/google/asurad... 
File src/mainboard/google/asurada/mainboard.c:

https://review.coreboot.org/c/coreboot/+/47008/1/src/mainboard/google/asurad... 
PS1, Line 101: if (!mainboard_regulator_is_enabled(MTK_REGULATOR_VCC))
             : 		mainboard_enable_requlator(MTK_REGULATOR_VCC, enable);
             : 	if (!mainboard_regulator_is_enabled(MTK_REGULATOR_VCCQ))
             : 		mainboard_enable_requlator(MTK_REGULATOR_VCCQ, enable);
will there be problems if we just call mainboard_enable_regulator without checking if it's already enabled?

or just do the check inside mainboard_enable_regulator?