Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46855 )
Change subject: mrc_cache: Move code for triggering memory training into mrc_cache ......................................................................
Patch Set 11:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46855/6/src/drivers/mrc_cache/mrc_c... File src/drivers/mrc_cache/mrc_cache.c:
https://review.coreboot.org/c/coreboot/+/46855/6/src/drivers/mrc_cache/mrc_c... PS6, Line 665: 0
I do think that we should keep the return type though. Otherwise how will we indicate errors? […]
Ok, I'll clean up the return value in the next CL.
https://review.coreboot.org/c/coreboot/+/46855/10/src/drivers/mrc_cache/mrc_... File src/drivers/mrc_cache/mrc_cache.c:
https://review.coreboot.org/c/coreboot/+/46855/10/src/drivers/mrc_cache/mrc_... PS10, Line 612: if (!CONFIG(HAS_RECOVERY_MRC_CACHE) && CONFIG(VBOOT_STARTS_IN_ROMSTAGE))
nit: since this is a static check and the one on line 603 is a dynamic one, it would be better to fl […]
Done.
https://review.coreboot.org/c/coreboot/+/46855/10/src/drivers/mrc_cache/mrc_... PS10, Line 708: "MRC: No region type found. " : "Skip adding to cbmem for type %d.\n",
No need to break print strings. They can be longer than the column limit.
Done