[coreboot-gerrit] Change in coreboot[master]: arch/x86: Attempt to boot without postcar stage/phase

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34752 )

Change subject: arch/x86: Attempt to boot without postcar stage/phase
......................................................................

Patch Set 4:

(5 comments)

https://review.coreboot.org/c/coreboot/+/34752/3/src/arch/x86/c_start.S 
File src/arch/x86/c_start.S:

https://review.coreboot.org/c/coreboot/+/34752/3/src/arch/x86/c_start.S@36 
PS3, Line 36: 	.code64
> We can't have the feature of this CL work with RAMSTAGE_X86_64. It would be broken.

Done

https://review.coreboot.org/c/coreboot/+/34752/3/src/arch/x86/c_start.S@42 
PS3, Line 42: _start:
> Can we get away with #include'ing exit_car. […]

Done

https://review.coreboot.org/c/coreboot/+/34752/3/src/arch/x86/c_start.S@45 
PS3, Line 45: ramstage_start:
> agree

Done

https://review.coreboot.org/c/coreboot/+/34752/3/src/arch/x86/c_start.S@48 
PS3, Line 48: 	lgdt	%cs:gdtaddr
> yes, we don;t need gdtinit in exit_car. […]

Done

https://review.coreboot.org/c/coreboot/+/34752/3/src/lib/program.ld 
File src/lib/program.ld:

https://review.coreboot.org/c/coreboot/+/34752/3/src/lib/program.ld@100 
PS3, Line 100: #if ENV_RMODULE || ENV_POSTCAR || CONFIG(RAMSTAGE_LOADS_FROM_ROMSTAGE)
> agree, i can modify kconfig and make depends on relocatable ramstage

Done, added depends