[coreboot-gerrit] [M] Change in coreboot[master]: cpu/intel/speedstep: Use acpigen_write_processor_device()

[Kyösti Mälkki (Code Review)]

Attention is currently required from: Nico Huber, Arthur Heymans.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74441 )

Change subject: cpu/intel/speedstep: Use acpigen_write_processor_device()
......................................................................

Patch Set 4:

(1 comment)

File src/southbridge/intel/i82801jx/fadt.c:

https://review.coreboot.org/c/coreboot/+/74441/comment/906d361c_9701b04e 
PS4, Line 25: 	fadt->p_lvl3_lat = 0;	/* FIXME: Is this correct? */
> Removing the FIXME probably won't get heads up. At least that's how I understand […]

Deprecation of Processor() object hides C2/C3 IO "trap" addresses (PROC_CNT or PROC_BLK +4 (C2) and +5 (C3)) from OSPM. If there is no _CST present, I see no mechanism to enter C2/C3 states?