Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39394 )
Change subject: WIP: inteltool: Add option to output GPIOs as coreboot macros ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/39394/1/util/inteltool/gpio_groups.... File util/inteltool/gpio_groups.c:
https://review.coreboot.org/c/coreboot/+/39394/1/util/inteltool/gpio_groups.... PS1, Line 100: host sw ownership missing
https://review.coreboot.org/c/coreboot/+/39394/1/util/inteltool/gpio_groups.... PS1, Line 148: if (rx_invert || rx_evcfg > 1) why is rx_evfcg == 3 not supported?
https://review.coreboot.org/c/coreboot/+/39394/1/util/inteltool/gpio_groups.... PS1, Line 149: return -1; we should print meaningful warnings/errors here
https://review.coreboot.org/c/coreboot/+/39394/1/util/inteltool/gpio_groups.... PS1, Line 168: case 0x1: nmi not supported?
https://review.coreboot.org/c/coreboot/+/39394/1/util/inteltool/gpio_groups.... PS1, Line 220: PAD_CFG_GPI_TRIG_OWN missing