build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30826 )
Change subject: security/tpm/tss/tcg-2.0: Add TPM2 function tlcl_getcapability() ......................................................................
Patch Set 5:
(7 comments)
https://review.coreboot.org/#/c/30826/5/src/security/tpm/tss.h File src/security/tpm/tss.h:
https://review.coreboot.org/#/c/30826/5/src/security/tpm/tss.h@73 PS5, Line 73: void *tpm_process_command(TPM_CC command, void *command_body, size_t *response_size); line over 80 characters
https://review.coreboot.org/#/c/30826/5/src/security/tpm/tss/tcg-1.2/tss.c File src/security/tpm/tss/tcg-1.2/tss.c:
https://review.coreboot.org/#/c/30826/5/src/security/tpm/tss/tcg-1.2/tss.c@3... PS5, Line 355: switch (in_digests[0].hashAlg) that open brace { should be on the previous line
https://review.coreboot.org/#/c/30826/5/src/security/tpm/tss/tcg-2.0/tss.c File src/security/tpm/tss/tcg-2.0/tss.c:
https://review.coreboot.org/#/c/30826/5/src/security/tpm/tss/tcg-2.0/tss.c@4... PS5, Line 417: response = tpm_process_command(TPM2_GetCapability, &cmd, &response_size); line over 80 characters
https://review.coreboot.org/#/c/30826/5/src/security/tpm/tss/vendor/cr50/cr5... File src/security/tpm/tss/vendor/cr50/cr50.c:
https://review.coreboot.org/#/c/30826/5/src/security/tpm/tss/vendor/cr50/cr5... PS5, Line 23: response = tpm_process_command(TPM2_CR50_VENDOR_COMMAND, &sub_command, NULL); line over 80 characters
https://review.coreboot.org/#/c/30826/5/src/security/tpm/tss/vendor/cr50/cr5... PS5, Line 46: response = tpm_process_command(TPM2_CR50_VENDOR_COMMAND, command_body, NULL); line over 80 characters
https://review.coreboot.org/#/c/30826/5/src/security/tpm/tss/vendor/cr50/cr5... PS5, Line 62: response = tpm_process_command(TPM2_CR50_VENDOR_COMMAND, &sub_command, NULL); line over 80 characters
https://review.coreboot.org/#/c/30826/5/src/security/tpm/tss/vendor/cr50/cr5... PS5, Line 79: response = tpm_process_command(TPM2_CR50_VENDOR_COMMAND, &mode_command, NULL); line over 80 characters