[coreboot-gerrit] Change in coreboot[master]: [WIP] mainboard: Add Acer ES1-572

[Felix Singer (Code Review)]

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38978 )

Change subject: [WIP] mainboard: Add Acer ES1-572
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/38978/4/src/mainboard/acer/es1-572/... 
File src/mainboard/acer/es1-572/romstage.c:

https://review.coreboot.org/c/coreboot/+/38978/4/src/mainboard/acer/es1-572/... 
PS4, Line 25: static void mainboard_fill_dq_map_data(void *dq_map_ch0, void *dq_map_ch1)
I don't think you need this, since there is no soldered RAM. Can be removed IMO.

https://review.coreboot.org/c/coreboot/+/38978/4/src/mainboard/acer/es1-572/... 
PS4, Line 37: static void mainboard_fill_dqs_map_data(void *dqs_map_ch0, void *dqs_map_ch1)
Same here.