[coreboot-gerrit] Change in coreboot[master]: drivers/intel/gma/acpi: Replace Subtract(a,b) with ASL 2.0 syntax

[Felix Singer (Code Review)]

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60497 )

Change subject: drivers/intel/gma/acpi: Replace Subtract(a,b) with ASL 2.0 syntax
......................................................................

drivers/intel/gma/acpi: Replace Subtract(a,b) with ASL 2.0 syntax

Replace `Subtract (a, b)` with `a - b`.

Change-Id: I4f6ffd6bbf6a37e041879e50fe41ce3cc856371f
Signed-off-by: Felix Singer 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/60497
Tested-by: build bot (Jenkins) 
Reviewed-by: HAOUAS Elyes 
---
M src/drivers/intel/gma/acpi/common.asl
M src/drivers/intel/gma/acpi/configure_brightness_levels.asl
2 files changed, 4 insertions(+), 6 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  HAOUAS Elyes: Looks good to me, approved

diff --git a/src/drivers/intel/gma/acpi/common.asl b/src/drivers/intel/gma/acpi/common.asl
index 254a66d..02169ae 100644
--- a/src/drivers/intel/gma/acpi/common.asl
+++ b/src/drivers/intel/gma/acpi/common.asl
@@ -9,7 +9,7 @@
    	Store (Match (BRIG, MEQ, Arg0, MTR, Zero, 2), Local0)
    	If (LEqual (Local0, Ones))
    	{
-			Return (Subtract(SizeOf(BRIG), One))
+			Return (SizeOf(BRIG) - 1)
    	}
    	Return (Local0)
    }
@@ -56,7 +56,7 @@
    		Notify (LCD0, 0x86)
    	} Else {
    		Store (BRID (XBQC ()), Local0)
-			If (LNotEqual (Local0, Subtract(SizeOf(BRIG), One)))
+			If (LNotEqual (Local0, SizeOf(BRIG) - 1))
    		{
    			Increment (Local0)
    		}
diff --git a/src/drivers/intel/gma/acpi/configure_brightness_levels.asl b/src/drivers/intel/gma/acpi/configure_brightness_levels.asl
index 92ae766..3581f4d 100644
--- a/src/drivers/intel/gma/acpi/configure_brightness_levels.asl
+++ b/src/drivers/intel/gma/acpi/configure_brightness_levels.asl
@@ -121,15 +121,13 @@

/* Local1: loop index (selectable values start at 2 in BRIG) */
    		Store (2, Local1)
-			While (LLess (Local1, Subtract (SizeOf (BRIG), 1))) {
+			While (LLess (Local1, SizeOf (BRIG) - 1)) {
    			/* Local[23]: adjacent values in BRIG */
    			Store (DeRefOf (BRIG[Local1]), Local2)
    			Store (DeRefOf (BRIG[Add (Local1, 1)]), Local3)

If (LLess (Local0, Local3)) {
-					If (LOr (LLess (Local0, Local2),
-						 LLess (Subtract (Local0, Local2),
-							Subtract (Local3, Local0)))) {
+					If (LOr (LLess (Local0, Local2), LLess (Local0 - Local2, Local3 - Local0))) {
    					Return (Local2)
    				} Else {
    					Return (Local3)

3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.