Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37455 )
Change subject: libpayload/drivers/i8042: If configured ignore all i8042 init failures ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37455/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37455/1//COMMIT_MSG@10 PS1, Line 10: failures are ignored.
Please elaborate, that you factor out common code, and that in the end you ignore only the QEMU work […]
Done
https://review.coreboot.org/c/coreboot/+/37455/1//COMMIT_MSG@11 PS1, Line 11:
Not everyone has access to the bug tracker, and you should not expect people using git to have acces […]
Done
https://review.coreboot.org/c/coreboot/+/37455/1/payloads/libpayload/drivers... File payloads/libpayload/drivers/i8042/keyboard.c:
https://review.coreboot.org/c/coreboot/+/37455/1/payloads/libpayload/drivers... PS1, Line 348: 0xf6
Please make that a separate commit, so each commit can be easily reverted in case of errors.
I changed my commit message to make it clear that this is cleaning up what was added in CB:23584, I think that changing a from a hardcoded value to something more well defined is in scope here.